Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect bitrate value returned from HMI to video encoder setting #1392

Closed
t-yoshii opened this issue Sep 2, 2019 · 2 comments
Closed

Reflect bitrate value returned from HMI to video encoder setting #1392

t-yoshii opened this issue Sep 2, 2019 · 2 comments
Labels
bug A defect in the library
Milestone
6.4.0

Comments

@t-yoshii
Copy link

t-yoshii commented Sep 2, 2019

Bug Report

Currently SDL iOS proxy ignores the bitrate value returned from HMI. This value should be reflected in the video encoder setting to perform VPM encoding/decoding smoothly.

Reproduction Steps

Connect VPM app to SDL Core.

Expected Behavior
  1. Connect the VPM app to SDL Core.
  2. Encoder setting reflects the value of bitrate in video streaming capabilities.
Observed Behavior
  1. Connect the VPM app to SDL Core.
  2. Encoder setting does not reflect the value of bitrate in video streaming capabilities.
OS & Version Information
  • iOS Version: all
  • SDL iOS Version: 6.3.1
  • Testing Against: Our internal devboard and OEM HMIs.
Test Case, Sample Code, and / or Example App

I will create PR.
@t-yoshii t-yoshii mentioned this issue Sep 2, 2019
Merged
1 task
@joeljfischer joeljfischer added the bug A defect in the library label Sep 4, 2019
@NicoleYarroch NicoleYarroch added this to the 6.4.0 milestone Sep 5, 2019
@NicoleYarroch
Copy link
Contributor

Fixed in PR #1393

@t-yoshii t-yoshii mentioned this issue Sep 26, 2019
Merged
1 task
@NicoleYarroch
Copy link
Contributor

Fixed in PR #1413

@joeljfischer joeljfischer mentioned this issue Oct 24, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in the library
Projects
None yet
Milestone
6.4.0
Development

No branches or pull requests
3 participants
@joeljfischer @t-yoshii @NicoleYarroch