Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMI responds with SUCCESS resultCode instead of WARNINGS to AddCommand with SecondaryImage in case isTemplate=true and image type is not .png #514

Closed
GetmanetsIrina opened this issue Mar 17, 2021 · 3 comments
Assignees
Labels
5.5.0 Release issues introduced by 5.5.0 release candidate bug

Comments

@GetmanetsIrina
Copy link

Description:
HMI responds with SUCCESS resultCode instead of WARNINGS to AddCommand request with SecondaryImage in case isTemplate=true and image type is not .png

Occurrence: 10/10

Preconditions:

  1. SDL and HMI are started
  2. The mobile app is registered and activated
  3. .jpg image is added successfully using PutFile RPC

Steps to reproduce:

  1. Mobile app requests AddCommand("SecondaryImage" ={ "value": <name>.jpg, "isTemplate" = true, "imageType" = "DYNAMIC" }, ... )

Expected behavior:
HMI receives UI.AddCommand("SecondaryImage" = { "value": <name>.jpg, "isTemplate" = true, "imageType" = "DYNAMIC" }) request and responds with WARNINGS result code

Observed behavior:
HMI responds with SUCCESS result code to UI.AddCommand request with the image not supported as a template

SDL -> HMI [16:41:7:825]: {"id":256,"jsonrpc":"2.0","method":"UI.AddCommand","params":{"appID":2015757036,"cmdID":2,"menuParams":{"menuName":"Item to Add 2","parentID":0,"position":0,"secondaryText":"Secondary text","tertiaryText":"Tertiary Text"},"secondaryImage":{"imageType":"DYNAMIC","isTemplate":true,"value":"/home/igetmanets/sdl/builds/DEVELOP/p/bin/storage/584421907_71546855d6279ef70d20909b292c42c2dcb02cd06bde01485da52d13e304ebf4/IMG_20210309_172030.jpg"}}}

UIRPC.js:157 FFW.UI.onRPCRequest
UIRPC.js:1790 FFW.UI.UI.AddCommandResponse
RPCClient.js:323 HMI -> SDL [16:41:7:833]: {"jsonrpc":"2.0","id":256,"result":{"code":0,"method":"UI.AddCommand"}}

Environment:
SDL: https://github.com/smartdevicelink/sdl_core/tree/develop (c9fc559)
HMI: https://github.com/smartdevicelink/sdl_hmi/tree/develop (41c804d)
SPT: SPT: 20210305-Android (1076)

@GetmanetsIrina
Copy link
Author

@jordynmackool, Please notice this issue is related to feature Main Menu UI Updates that should be released in the 7.1 release.

@Ypostolov
Copy link
Contributor

Luxoft is working on it.

@jordynmackool jordynmackool added the 5.5.0 Release issues introduced by 5.5.0 release candidate label Mar 22, 2021
@LitvinenkoIra LitvinenkoIra self-assigned this Mar 22, 2021
@iCollin
Copy link
Collaborator

iCollin commented Mar 24, 2021

Closed via #544

@iCollin iCollin closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.5.0 Release issues introduced by 5.5.0 release candidate bug
Projects
None yet
Development

No branches or pull requests

5 participants