Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microphone format not set, settings from PerformAudioPassThru request ignored by OnAudioPassThru notification #491

Closed
chrisdrehernuance opened this issue Apr 14, 2016 · 4 comments
Labels

Comments

@chrisdrehernuance
Copy link

chrisdrehernuance commented Apr 14, 2016

The OnAudioPassThru notification sends microphone audio data from the headunit to the mobile device as binary PCM data (preceded by a wav file header). Unfortunately, this data does not match the PCM format requested in the preceding PerformAudioPassThru request from the phone.

For example, PerformAudioPassThru can request microphone audio data in a format of 8-bit PCM at 22KHz but OnAudioPassThru will return data in the OS's default format (ex: 16-bit 44KHz).

Recommend updating the file from_mic_to_file_recorder_thread.cc to set the sampling Hz, the bits-per-sample, and number of channels.

@LitvinenkoIra
Copy link
Contributor

Priority Low.
Offer for enhancement, not a defect.

@Jack-Byrne
Copy link
Collaborator

@chrisdrehernuance That audio format might not be supported by the head unit. Please check the audioPassThruCapabilities struct in the Register App Interface response. Also having multiple supported audioPassThruCapabilities is an accepted proposal. Please refer to this proposal which will be implemented into core in the future. https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0138-hmi-audiopassthru-capability.md

@shoamano83
Copy link
Contributor

Hi, I have fixed this issue internally and would like to contribute it. I know this ticket has been closed, but please verify my PR if you like: #2184. Thanks.

@ShobhitAd ShobhitAd reopened this Jun 30, 2020
@ShobhitAd
Copy link
Contributor

Closed via #2184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants