CCB: Use weak_ptr<WebsocketSession> instead of raw ptrs

[LitvinenkoIra]

Bug Report

Use weak_ptr instead of raw ptrs

Detailed analysis:

Its a reason for possible SIGSEGVs. It's bad practice to use raw pointers to WebsocketSession in almost all cases. For function arguments, pointers should be changed to references for preventing null pointer occurrence. For containers pointers should be changed to weak_ptr for preventing
expired references. Wrong inheritance for CMessageBrokerController should be removed.

Reproduction Steps

1. TBD

Expected Behavior

SDL should not crash

Observed Behavior

SDL crashed

OS & Version Information

• OS/Version : SYNC4
• SDL Core Version: https://github.com/smartdevicelink/sdl_core/releases/tag/5.0.1
• Testing Against: SYNC4 Applink

[E-SAITO-TMC]

@joeygrover -san @theresalech -san This issue is a high priority for Toyota. Could you please tell me reproduction steps? Also, Does this issue occur in the latest version?

[theresalech]

Hi @E-SAITO-TMC, we have documented that this is priority for Toyota, and will include for Steering Committee review and vote when planning the contents for the Q4 Core release. This planning will take place in June.
@LitvinenkoIra, can you please provide reproduction steps for this issue? If you could also advise if the Luxoft team is seeing this issue in Core 6.1, that would be most helpful!

[LuxoftAKutsan]

This issue has ho reproduction steps.
It was found by the Hellgrind dynamic code analysis tool in the SYNC environment.
6.1 do not contain the fix and the issue is possible.
SYNC changes need to be ported on open sdl_core.

[theresalech]

@LuxoftAKutsan thank you for the update. Please advise when a PR has been submitted.

[AKalinich-Luxoft]

@theresalech fix has been submitted and ready for Livio review

[ShobhitAd]

Closed via #3490