Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check before accessing packetWriteMap #957

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

joeygrover
Copy link
Member

Fixes #951

This PR is ready for review.

Risk

This PR makes no API changes.

Summary

  • Added a null check before accessing offending variable

Changelog

Bug Fixes
  • Prevent NPE during a router service shutdown

CLA

@codecov-io
Copy link

codecov-io commented Dec 21, 2018

Codecov Report

Merging #957 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #957      +/-   ##
=============================================
- Coverage      42.55%   42.55%   -0.01%     
  Complexity      3735     3735              
=============================================
  Files            434      434              
  Lines          23098    23099       +1     
  Branches        2698     2699       +1     
=============================================
  Hits            9829     9829              
- Misses         12623    12624       +1     
  Partials         646      646
Impacted Files Coverage Δ Complexity Δ
...om/smartdevicelink/transport/SdlRouterService.java 7.19% <0%> (-0.01%) 9 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d329a1...0f3746a. Read the comment docs.

@bilal-alsharifi bilal-alsharifi merged commit a4e794d into develop Jan 14, 2019
@bilal-alsharifi bilal-alsharifi deleted the bugfix/issue_951 branch January 14, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants