Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential NPE for transportType during write #956

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

joeygrover
Copy link
Member

Fixes #945

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • Send a packet to router service to send while no transport is connected.

Summary

  • If no transport type is supplied and no transport is currently connected. The write task runnable will simply return instead of trying to write the packet while not supplying a transport type.

Changelog

Bug Fixes
  • There is likely a race condition where the packet write runnable can be mid or starting execution as the router service is disconnecting or already disconnected.

CLA

There is likely a race condition where the runnable can be mid or starting execution as the router service is disconnecting or already disconntected.
@codecov-io
Copy link

codecov-io commented Dec 21, 2018

Codecov Report

Merging #956 into develop will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #956      +/-   ##
=============================================
+ Coverage      42.55%   42.58%   +0.03%     
  Complexity      3735     3735              
=============================================
  Files            434      434              
  Lines          23098    23100       +2     
  Branches        2698     2698              
=============================================
+ Hits            9829     9837       +8     
+ Misses         12623    12615       -8     
- Partials         646      648       +2
Impacted Files Coverage Δ Complexity Δ
...om/smartdevicelink/transport/SdlRouterService.java 7.19% <0%> (-0.01%) 9 <0> (ø)
...smartdevicelink/encoder/VirtualDisplayEncoder.java 29.31% <0%> (+4.59%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d329a1...1b80ecd. Read the comment docs.

@bilal-alsharifi bilal-alsharifi merged commit 3f33970 into develop Jan 14, 2019
@bilal-alsharifi bilal-alsharifi deleted the bugfix/issue_945 branch January 14, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants