Add ability for RPCs to be versioned/formatted #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens on marshalling and when the proxy base handles incomming messages. Subparams will be formated on retrieval when RPCs are retrieved due to them being stored as hashmaps instead of their actual RPC structs.
For method in JSONRPCMarsaller
joeygrover
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #839 +/- ##
============================================
+ Coverage 43.41% 43.8% +0.39%
- Complexity 3029 3038 +9
============================================
Files 382 383 +1
Lines 17461 17795 +334
Branches 1736 1750 +14
============================================
+ Hits 7580 7795 +215
- Misses 9563 9672 +109
- Partials 318 328 +10
Continue to review full report at Codecov.
|
BrettyWhite
reviewed
Aug 22, 2018
| this.rpcSpecVersion = rpcSpecVersion; | ||
| lFileSize = lLength; | ||
| iInitialCorrID = request.getCorrelationID(); | ||
| mPauseLock = new Object(); |
| formatRequested = true; | ||
| rpcSpecVersion = rpcVersion; | ||
| //Should override this method when breaking changes are made to the RPC spec | ||
| if(formatParams == true && store != null){ |
There was a problem hiding this comment.
AS keeps suggesting simplifying the condition like this
if(formatParams && store != null)
askirk
approved these changes
Aug 22, 2018
in StreamRPCPacketizer
bilal-alsharifi
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for review.
Risk
This PR makes minor API changes.
Summary
RPC Struct now has a format method that can be used to properly format RPCs based on the rpc spec version
CLA