ScreenManager does not call completion listener if TextAndGraphicManager is not dirty

[PoisonousJohn]

Bug Report

I had a bug in my app which fired multiple RPCs to update UI via ScreenManager.
I've spent a day debugging the case, and find out that ScreenManager.commit callback was not fired.

Digging down showed it was due to TextAndGraphicManager.isDirty is false, thus the following code would not invoke listener.

		softButtonManager.update(new CompletionListener() {
			boolean updateSuccessful = true;
			@Override
			public void onComplete(boolean success) {
				if (!success){
					updateSuccessful = false;
				}
				textAndGraphicManager.setBatchUpdates(false);
				textAndGraphicManager.update(new CompletionListener() {
					@Override
					public void onComplete(boolean success) {
                                                  // this method is never called
						if (!success){
							updateSuccessful = false;
						}
						listener.onComplete(updateSuccessful);
					}
				});
			}
		});

Reproduction Steps

Not sure about exact steps but try the following.

1. update some ui using ScreenManager
2. Invoke setSoftButtons() right inside ScreenManager.commit()
3. Repeat the same operation immediately

Expected Behavior

ScreenManager.commit callback should be called

Observed Behavior

ScreenManager.commit callback is never called for the second request.

OS & Version Information

• Android Version: 9
• SDL Android Version: implementation 'com.smartdevicelink:sdl_android:4.+'
• Testing Against: Emulator

Test Case, Sample Code, and / or Example App

            getManager().getScreenManager().beginTransaction();
            interfaceChanger.run();
            getManager().getScreenManager().commit(success -> {
                  // here I call set soft buttons
                  // then I start the same process again
            });