From f44ada017eac4f607ffeb1caca96a2347d48f38f Mon Sep 17 00:00:00 2001
From: Thomas Landauer <thomas@landauer.at>
Date: Tue, 3 Dec 2024 13:01:10 +0100
Subject: [PATCH] Some more exceptions (#745)

---
 src/Smalot/PdfParser/Document.php                    |  5 +++--
 .../Exception/InvalidDictionaryObjectException.php   | 12 ++++++++++++
 .../PdfParser/Exception/MissingCatalogException.php  | 12 ++++++++++++
 src/Smalot/PdfParser/PDFObject.php                   |  5 +++--
 4 files changed, 30 insertions(+), 4 deletions(-)
 create mode 100644 src/Smalot/PdfParser/Exception/InvalidDictionaryObjectException.php
 create mode 100644 src/Smalot/PdfParser/Exception/MissingCatalogException.php

diff --git a/src/Smalot/PdfParser/Document.php b/src/Smalot/PdfParser/Document.php
index 964592e4..a44b133a 100644
--- a/src/Smalot/PdfParser/Document.php
+++ b/src/Smalot/PdfParser/Document.php
@@ -33,6 +33,7 @@
 namespace Smalot\PdfParser;
 
 use Smalot\PdfParser\Encoding\PDFDocEncoding;
+use Smalot\PdfParser\Exception\MissingCatalogException;
 
 /**
  * Technical references :
@@ -379,7 +380,7 @@ public function getFirstFont(): ?Font
     /**
      * @return Page[]
      *
-     * @throws \Exception
+     * @throws MissingCatalogException
      */
     public function getPages()
     {
@@ -415,7 +416,7 @@ public function getPages()
             return array_values($pages);
         }
 
-        throw new \Exception('Missing catalog.');
+        throw new MissingCatalogException('Missing catalog.');
     }
 
     public function getText(?int $pageLimit = null): string
diff --git a/src/Smalot/PdfParser/Exception/InvalidDictionaryObjectException.php b/src/Smalot/PdfParser/Exception/InvalidDictionaryObjectException.php
new file mode 100644
index 00000000..745bd574
--- /dev/null
+++ b/src/Smalot/PdfParser/Exception/InvalidDictionaryObjectException.php
@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Smalot\PdfParser\Exception;
+
+/**
+ * This exception is thrown when an invalid dictionary object is encountered.
+ */
+class InvalidDictionaryObjectException extends \Exception
+{
+}
diff --git a/src/Smalot/PdfParser/Exception/MissingCatalogException.php b/src/Smalot/PdfParser/Exception/MissingCatalogException.php
new file mode 100644
index 00000000..d29cdc90
--- /dev/null
+++ b/src/Smalot/PdfParser/Exception/MissingCatalogException.php
@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Smalot\PdfParser\Exception;
+
+/**
+ * This exception is thrown when the catalog is missing.
+ */
+class MissingCatalogException extends \Exception
+{
+}
diff --git a/src/Smalot/PdfParser/PDFObject.php b/src/Smalot/PdfParser/PDFObject.php
index 2c33e0e9..73b3058a 100644
--- a/src/Smalot/PdfParser/PDFObject.php
+++ b/src/Smalot/PdfParser/PDFObject.php
@@ -32,6 +32,7 @@
 
 namespace Smalot\PdfParser;
 
+use Smalot\PdfParser\Exception\InvalidDictionaryObjectException;
 use Smalot\PdfParser\XObject\Form;
 use Smalot\PdfParser\XObject\Image;
 
@@ -559,7 +560,7 @@ private function getTJUsingFontFallback(Font $font, array $command, ?Page $page
      *
      * @internal
      *
-     * @throws \Exception
+     * @throws InvalidDictionaryObjectException
      */
     public function parseDictionary(string $dictionary): array
     {
@@ -567,7 +568,7 @@ public function parseDictionary(string $dictionary): array
         $dictionary = preg_replace(['/\r/', '/\n/', '/\s{2,}/'], ' ', trim($dictionary));
 
         if ('<<' != substr($dictionary, 0, 2)) {
-            throw new \Exception('Not a valid dictionary object.');
+            throw new InvalidDictionaryObjectException('Not a valid dictionary object.');
         }
 
         $parsed = [];