New Feature: Fail when item is present

[AlexandreGuidin]

Hi everyone!

I would like to fail with a exception, if a Uni<> has a not null item.

i've coded this today:

profileRepository.findByEmail("[email protected]")
                .onItem().ifNotNull().call(p -> {throw new ValidationException("email", "already registered");})

But i didnt like it, it could be better

Idea of new API:

profileRepository.findByEmail("[email protected]")
                .onItem().ifNotNull().failWith(() -> new ValidationException("email", "already registered"))

[heubeck]

Why not using uni.onItem().ifNotNull().transformToUni(Uni.createFrom().failure(new ValidationException("email", "already registered"))?

[cescoffier]

There is a failWith method in some groups. I believe we forgot to have it everywhere.

[jponge]

Let's link to #608

[jponge]

We indeed have a failWith operator, @AlexandreGuidin fancy a PR?

[AlexandreGuidin]

Why not using uni.onItem().ifNotNull().transformToUni(Uni.createFrom().failure(new ValidationException("email", "already registered"))?

That's better than the first option!

We indeed have a failWith operator, @AlexandreGuidin fancy a PR?

I've never contributed to a open-source project, but i could try, it should be simple 👀

[AlexandreGuidin]

Ok, i've cloned the repo and add some code/tests, it works, how contributions works ? I need write permission to push it

[jponge]

You need to open a PR from your (non-main) branch to this repository

[jponge]

See https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

[AlexandreGuidin]

Everyone has access to push a new branch to the origin ?

➜  smallrye-mutiny git:(feature/uninotnull-fail) gpsup
ERROR: Permission to smallrye/smallrye-mutiny.git denied to AlexandreGuidin.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

the alias gpsup means => git push --set-upstream origin feature/uninotnull-fail

I've checked my SSH with other project, it's working 😄

[jponge]

You need to push to your own fork, you don't have permissions on this repo.

[AlexandreGuidin]

PR Created #627