Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between MultiConcat and MultiMerge #516

Closed
oliver-brm opened this issue Apr 1, 2021 · 3 comments
Closed

Discrepancy between MultiConcat and MultiMerge #516

oliver-brm opened this issue Apr 1, 2021 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@oliver-brm
Copy link
Contributor

In Mutiny 0.15.0, MultiConcat and MultiMerge differ slightly in the method signature of streams(...:

MultiMerge.java:

public <T> Multi<T> streams(Iterable<Publisher<T>> iterable) {

MultiConcat.java:

public <T> Multi<T> streams(Iterable<? extends Publisher<T>> iterable) {

Is the method in MultiMerge not allowing Iterable<? extends Publisher<T>> on purpose? That way, we can't use, for example, a List<Multi<T>> as parameter.

@jponge
Copy link
Member

jponge commented Apr 1, 2021

Good point, this is worth a PR

@oliver-brm
Copy link
Contributor Author

Working on it :-)

@jponge jponge added this to the 0.16.0 milestone Apr 1, 2021
@jponge jponge added the bug Something isn't working label Apr 1, 2021
@jponge
Copy link
Member

jponge commented Apr 1, 2021

Fixed by #517

@jponge jponge closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants