Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve combination/merging/concatenation API #158

Closed
cescoffier opened this issue Jun 8, 2020 · 3 comments
Closed

Improve combination/merging/concatenation API #158

cescoffier opened this issue Jun 8, 2020 · 3 comments
Assignees
@jponge
Labels
on-roadmap The issue is part of the roadmap
Milestone
1.4.0

Comments

@cescoffier
Copy link
Contributor

Right now:

Uni.combine().all/any
Multi.createBy().combining/merging/concatenating

Also, when dealing with dynamic lists, the API requires to use a collection and then invoke. A builder approach would be better:

UniAllBuilder builder = Uni.combine().all();
builder.add(uni1);
builder.add(uni2);
Uni<X> uni = builder.combineWith(combinator);
@cescoffier cescoffier added the on-roadmap The issue is part of the roadmap label Jun 8, 2020
@jponge jponge self-assigned this Mar 19, 2021
@jponge jponge mentioned this issue Jun 21, 2021
Closed
@jponge
Copy link
Member

jponge commented Jun 30, 2021

#604 is a draft for Uni.combine.

@jponge
Copy link
Member

jponge commented Jul 26, 2021

Half of this issue has been addressed in #604

Future works will focus on what can be done on the Multi side.

@jponge jponge added this to the 1.4.0 milestone Feb 3, 2022
@jponge
Copy link
Member

jponge commented Feb 3, 2022

I think we've done well on this front during the past releases and the upcoming 1.4.0.

@jponge jponge closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jponge jponge

Labels
on-roadmap The issue is part of the roadmap
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@jponge @cescoffier