Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the protected modified back to getDefaultSources() #1085

Closed
jakub-pomykala opened this issue Jan 11, 2024 · 0 comments · Fixed by #1086
Closed

Add the protected modified back to getDefaultSources() #1085

jakub-pomykala opened this issue Jan 11, 2024 · 0 comments · Fixed by #1086

Comments

@jakub-pomykala
Copy link
Contributor

jakub-pomykala commented Jan 11, 2024 •
edited
Loading

In 3.5.0 the protected modifier was removed from SmallRyeConfigBuilder.getDefaultSources() (here)

I am currently trying to update the SmallRye version that we are using to 3.5.1 but because getDefaultSources is no longer protected; our implementation is now causing failures as we are no longer able to Override and extend this method.
@jakub-pomykala jakub-pomykala changed the title Make getDefaultSources() protected so it can be overriden and extended Add the protected modified back to getDefaultSources() Jan 11, 2024
This was referenced Jan 11, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jakub-pomykala