Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch mongodb deployment from Hono helm chart to Bitnami chart #56

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Switch mongodb deployment from Hono helm chart to Bitnami chart #56

merged 2 commits into from
Apr 2, 2021

Conversation

JouHouFin
Copy link
Collaborator

Up to this point, we have deployed MongoDB via Hono helm chart, which has quite limited (or difficult) configuration options. Commit e7167db switches MongoDB deployment to use the Bitnami MongoDB helm chart.

Tested to be working, but currently has rather basic configuration.

Linked to #38, but the question of data persistence is still open.

@JouHouFin JouHouFin added question Further information is requested safe-to-test PR's that are safe to test with the pipeline labels Mar 20, 2021
@JouHouFin JouHouFin requested review from wisack, msrn and Nindemic March 20, 2021 14:18
@JouHouFin
Copy link
Collaborator Author

Commit 802181d switches to using set_sensitive when dealing with sensitive values.

@msrn msrn added safe-to-test PR's that are safe to test with the pipeline question Further information is requested and removed question Further information is requested safe-to-test PR's that are safe to test with the pipeline labels Mar 23, 2021
@JouHouFin
Copy link
Collaborator Author

JouHouFin commented Apr 2, 2021 •
edited
Loading

Commit 3c0b87e:

  • switches to using mongo_values.yaml for non-sensitive values
  • adds a PersistentVolumeClaim named mongodb-data, that will use azure-disk-retain -StorageClass. This PVC is used by mongodb deployment.

In essence, #38 is fulfilled by this commit, but we we haven't tested if e.g. registered tenants are intact after bringing Hono down and up again.

@JouHouFin JouHouFin merged commit c9caf41 into smaddis:master Apr 2, 2021
@msrn msrn linked an issue Apr 2, 2021 that may be closed by this pull request
Use customized external MongoDB with Hono #38
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msrn msrn msrn left review comments

@wisack wisack Awaiting requested review from wisack

@Nindemic Nindemic Awaiting requested review from Nindemic

Assignees
No one assigned
Labels
question Further information is requested safe-to-test PR's that are safe to test with the pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use customized external MongoDB with Hono
2 participants
@JouHouFin @msrn