Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{beam_location}: removed updating state if unnecessary #475

Merged
merged 6 commits into from
Feb 11, 2022
Merged

{beam_location}: removed updating state if unnecessary #475

merged 6 commits into from
Feb 11, 2022

Conversation

jmysliv
Copy link
Contributor

@jmysliv jmysliv commented Feb 8, 2022

description in the: #474
closes #474

@jmysliv jmysliv mentioned this pull request Feb 8, 2022
Closed
@Qizot
Copy link

Qizot commented Feb 9, 2022

LGTM!

@slovnicki
Copy link
Owner

Thanks for the PR @jmysliv! 💙
I will review it shortly

@slovnicki slovnicki self-requested a review February 10, 2022 12:47
@codecov
Copy link

codecov bot commented Feb 10, 2022 •
edited
Loading

Codecov Report

Merging #475 (d3981bc) into master (75e05e9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d3981bc differs from pull request most recent head 3123e3f. Consider uploading reports for the commit 3123e3f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage   96.11%   96.11%   -0.01%     
==========================================
  Files          13       13              
  Lines         798      797       -1     
==========================================
- Hits          767      766       -1     
  Misses         31       31
Impacted Files Coverage Δ
package/lib/src/beamer_delegate.dart 93.04% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a9460...3123e3f. Read the comment docs.

@jmysliv jmysliv requested a review from slovnicki February 11, 2022 08:23
@slovnicki slovnicki self-requested a review February 11, 2022 13:58
slovnicki
slovnicki approved these changes Feb 11, 2022
View reviewed changes
Copy link
Owner

@slovnicki slovnicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Thanks again for the PR @jmysliv 💙

@slovnicki slovnicki merged commit e6d6596 into slovnicki:master Feb 11, 2022
@ryanaston ryanaston mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slovnicki slovnicki slovnicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom State is being updated unnecessary which results in StackOverflowError
3 participants
@jmysliv @Qizot @slovnicki