lsp: Offer to populate empty documents #4767
Conversation
|
Of course this only shows while the file does not contain anything but whitespace:-) |
There was a problem hiding this comment.
Nice. I like it.
I think only one option is enough though.
Probably the Hello World like so:
import { AboutSlint, VerticalBox } from "std-widgets.slint";
export component MainWindow inherits Window {
VerticalBox {
alignment: start;
Text { text: "Hello World!"; }
AboutSlint { preferred-height: 150px; }
}
}
Make it a window by default. But keep it as short as possible while still have something somehow visual.
Did you try if it worked in a slint!{} macro?
|
We need to remember which area of the document we are actually touching... otherwise this just can not work. |
|
The latest set of commits add an ASCII start-of-text and end-of-text byte around the area covered by It then limits the actions to the range between these markers (if present). That way it works with the slint! macro BUT there is a bug still: When you remove the slint macro, the LSP will not update its document cache accordingly and will insist that the code lense needs to continue to exist. That needs fixing :-/ |
This is so we can use the ASCII Start-of-Text and End-of-Text control characters as markers in files containing blocks of Slint code embedded into other things. SOT and EOT are ASCII control characters, so they are one byte and thus will basically fit into whatever markup is used to separate Slint code form whatever else surrounds it.
|
We have document invalidation now, so I needed to rebase this PR and take a look again. The code lens now goes away again when the |
|
... and now we actually invalidate rust files that loose their |
Add `Start-of-text` ASCII value in the place of the opening brace of the slint macro and `End-of-text` in place of the closing bracket. ASCII chars are one byte, so they will always work :-)
... so we do not keep stray code lenses around (and probably not end up having other issues down the line).
| content = match i_slint_compiler::lexer::extract_rust_macro(content) { | ||
| Some(content) => content, | ||
|
|
||
| let action = if path.extension().map_or(false, |e| e == "rs") { |
There was a problem hiding this comment.
| let action = if path.extension().map_or(false, |e| e == "rs") { | |
| let action = if path.extension().is_some_and(|e| e == "rs") { |
| FileAction::InvalidateFile => { | ||
| if let Some(ctx) = ctx { | ||
| ctx.server_notifier.send_message_to_preview( | ||
| common::LspToPreviewMessage::FileLost { url: url.clone() }, |
There was a problem hiding this comment.
FileLost? How can we lose a file? 😉
| command: Some(create_populate_command( | ||
| text_document.uri.clone(), | ||
| version.clone(), | ||
| "Start with fixed size Window".to_string(), |
There was a problem hiding this comment.
not sure we need that. I don't think we should confuse the user with too many choices
So when snippets do not work: Let's try something else to get started from scratch:-)