Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better defn of cookie configs #11

Open
bkardell opened this issue Feb 24, 2013 · 1 comment
Open

better defn of cookie configs #11

bkardell opened this issue Feb 24, 2013 · 1 comment

Comments

@bkardell
Copy link
Contributor

It seems several of the config options (days to prompt, etc) would be inherently senseless if allowCookies were false. This makes it harder to understand/explain, also, now that there are N independent configs, this is even harder... What if one config says cookies and another doesn't...

Feels like cookies deserve their own config with sensible defaults.
@slightlyoff
Copy link
Owner

if allowCookies is false, it seems to me that would be the same as prompting every time. I don't think that configs on a page disagreeing is particularly our problem, but I do support having separate cookie config for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slightlyoff @bkardell