-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligned or nearest seam position on convex vertex when a concave non overhang vertex available #4268
Comments
I tried to investigate that further in order to provide a simple example showing the issue. This is the resulting gcode, seam position setting "nearest": What happens?On the left: Slicer does not use the concav vertex where the seam would be less visible. It uses a convex vertex. What is expected?Slicer should use the concave vertex in both cases. Help file says about "nearest":
Slicer seems to ignore the vertex because the angle is higher than 120° (in the example, it is 120.1°). But I think the concav vertex should still be preferred over the convex vertex and the convex vertex should always be preferred over a otherwise smooth surface. |
I wonder how the Slic3r Prusa Edition would compare to the upstream Slic3r in this regard. The Slic3r PE implements a somehow different heuristics, and it also tries to avoid overhangs. |
Hi bubnikv, Now, what is SlicerPE doing? So in the end the concave vertices should get a penalty of nearly 0, because the angle of 120.1° is just slightly greater than 108°. The convex vertice will get a penalty of nearly 1, because the angle of 90° is slightly smaller than 108°. But because the convex vertice is nearer to the last point, it gets enough bonus to win over the concave vertice. We should discuss if we should change the limits of slicers vertice recognition or if it wouldn't be better to follow PrusaPE's approach of the penalty model. That would also allow for implementing a preferred seam location (requested in #2911) by coordinates. Edit: Added Reference to SlicerPE Feature Request #342 and Pull Request #728. |
I'd be happy to accept a PR if you want to take a swing at implementing better seam placement in Slic3r. |
Thank you for that offer. |
Version
19ea7a5
Operating system type + version
Win 7 64bit
Behavior
slicer not always uses concave non overhang vertex for start/end point of outer perimeter.
In this example, seam position is "nearest" and the concav vertex inside is not overhanging, I do not see why slic3r doesn't use it.
In general, I'd find it useful to specify the seam position as nearest to some Point (X, Y) like in S3D. We print half shells and the inside is hidden, so it would be perfect to have the seam at the inside. This is not achievable with "rear" setting. But it may be best to open a feature request for that... ;-)
The text was updated successfully, but these errors were encountered: