From 3a86ce1d1de844d4fd79554dec308cd571a386f2 Mon Sep 17 00:00:00 2001
From: Tamas Nemeth <treff7es@gmail.com>
Date: Mon, 2 Dec 2024 10:03:06 +0100
Subject: [PATCH] fix[ingest/build]: Disable preflight script as it is not
 needed anymore (#11989)

---
 metadata-ingestion/build.gradle               |  10 +-
 .../scripts/datahub_preflight.sh              | 108 ------------------
 2 files changed, 1 insertion(+), 117 deletions(-)
 delete mode 100755 metadata-ingestion/scripts/datahub_preflight.sh

diff --git a/metadata-ingestion/build.gradle b/metadata-ingestion/build.gradle
index 4e3f1ca91766c2..4e03dd6e2faaf2 100644
--- a/metadata-ingestion/build.gradle
+++ b/metadata-ingestion/build.gradle
@@ -30,15 +30,7 @@ task environmentSetup(type: Exec, dependsOn: checkPythonVersion) {
     "touch ${sentinel_file}"
 }
 
-task runPreFlightScript(type: Exec, dependsOn: environmentSetup) {
-  def sentinel_file = ".preflight_sentinel"
-  outputs.file(sentinel_file)
-  commandLine 'bash', '-c',
-    "scripts/datahub_preflight.sh && " +
-    "touch ${sentinel_file}"
-}
-
-task installPackageOnly(type: Exec, dependsOn: runPreFlightScript) {
+task installPackageOnly(type: Exec, dependsOn: environmentSetup) {
   def sentinel_file = "${venv_name}/.build_install_package_only_sentinel"
   inputs.file file('setup.py')
   outputs.file(sentinel_file)
diff --git a/metadata-ingestion/scripts/datahub_preflight.sh b/metadata-ingestion/scripts/datahub_preflight.sh
deleted file mode 100755
index 9676964f4d49d1..00000000000000
--- a/metadata-ingestion/scripts/datahub_preflight.sh
+++ /dev/null
@@ -1,108 +0,0 @@
-#!/bin/bash -e
-
-#From https://stackoverflow.com/questions/4023830/how-to-compare-two-strings-in-dot-separated-version-format-in-bash
-verlte() {
-  [  "$1" == "$(echo -e "$1\n$2" | sort -V | head -n1)" ]
-}
-
-brew_install() {
-    package=${1}
-    required_version=${2}
-    printf '\n🔎 Checking if %s installed\n' "${package}"
-    version=$(brew list --version|grep "$1"|awk '{ print $2 }')
-
-    if [ -n "${version}" ]; then
-      if [ -n "$2" ] && ! verlte "${required_version}" "${version}"; then
-        printf '🔽 %s is installed but its version %s is lower than the required %s\n' "${package}" "${version}" "${required_version}. Updating version..."
-        brew update && brew upgrade "$1" && printf '✅ %s is installed\n' "${package}"
-      else
-        printf '✅ %s is already installed\n' "${package} with version ${version}"
-      fi
-    else
-        brew install "$1" && printf '✅ %s is installed\n' "${package}"
-    fi
-}
-
-arm64_darwin_preflight() {
-  printf "✨ Creating/activating Virtual Environment\n"
-  python3 -m venv venv
-  source venv/bin/activate
-
-  printf "🔎 Checking if Scipy installed\n"
-  if pip list | grep -F scipy; then
-  	printf "✅ Scipy already installed\n"
-  else
-  	printf "Scipy not installed\n"
-  	printf "⛅ Installing prerequisities for scipy"
-  	brew install openblas
-  	OPENBLAS="$(brew --prefix openblas)"
-  	export OPENBLAS
-  	##preinstall numpy and pythran from source
-  	pip3 uninstall -y numpy pythran
-  	pip3 install cython pybind11
-  	pip3 install --no-use-pep517 numpy
-  	pip3 install pythran
-  	pip3 install --no-use-pep517 scipy
-  fi
-
-  brew_install "openssl@1.1"
-  brew install "postgresql@14"
-
-  # postgresql installs libs in a strange way
-  # we first symlink /opt/postgresql@14 to /opt/postgresql
-  if [ ! -z $(brew --prefix)/opt/postgresql ]; then
-    printf "✨ Symlinking postgresql@14 to postgresql\n"
-    ln -sf $(brew --prefix postgresql@14) $(brew --prefix)/opt/postgresql
-  fi
-  # we then symlink all libs under /opt/postgresql@14/lib/postgresql@14 to /opt/postgresql@14/lib
-  if [ ! -z $(brew --prefix postgresql@14)/lib/postgresql@14 ]; then
-    printf "✨ Patching up libs in $(brew --prefix postgresql@14)/lib/postgresql@14)\n"
-    ln -sf $(brew --prefix postgresql@14)/lib/postgresql@14/* $(brew --prefix postgresql@14)/lib/
-  fi
-
-  printf "\e[38;2;0;255;0m✅ Done\e[38;2;255;255;255m\n"
-
-  printf "✨ Setting up environment variable:\n"
-  GRPC_PYTHON_BUILD_SYSTEM_OPENSSL=1
-  export GRPC_PYTHON_BUILD_SYSTEM_OPENSSL
-  GRPC_PYTHON_BUILD_SYSTEM_ZLIB=1
-  export GRPC_PYTHON_BUILD_SYSTEM_ZLIB
-  CPPFLAGS="-I$(brew --prefix openssl@1.1)/include"
-  export CPPFLAGS
-  LDFLAGS="-L$(brew --prefix openssl@1.1)/lib"
-  export LDFLAGS
-
-cat << EOF
-  export GRPC_PYTHON_BUILD_SYSTEM_OPENSSL=1
-  export GRPC_PYTHON_BUILD_SYSTEM_ZLIB=1
-  export CPPFLAGS="-I$(brew --prefix openssl@1.1)/include"
-  export LDFLAGS="-L$(brew --prefix openssl@1.1)/lib -L$(brew --prefix postgresql@14)/lib/postgresql@14"
-
-EOF
-
-  if pip list | grep -F confluent-kafka; then
-    printf "✅ confluent-kafka already installed\n"
-  else
-    pip3 install confluent-kafka
-  fi
-
-  printf "✨ Setting up prerequisities\n"
-  # none for now, since jq was removed
-
-  printf "\e[38;2;0;255;0m✅ Done\e[38;2;255;255;255m\n"
-}
-
-
-printf "🔎 Checking if current directory is metadata-ingestion folder\n"
-if [ "$(basename "$(pwd)")"	 != "metadata-ingestion" ]; then
-	printf "💥 You should run this script in Datahub\'s metadata-ingestion folder but your folder is %s\n" "$(pwd)"
-	exit 123
-fi
-printf '✅ Current folder is metadata-ingestion (%s) folder\n' "$(pwd)"
-if [[ $(uname -m) == 'arm64' && $(uname) == 'Darwin' ]]; then
-  printf "👟 Running preflight for m1 mac\n"
-  arm64_darwin_preflight
-fi
-
-
-printf "\n\e[38;2;0;255;0m✅ Preflight was successful\e[38;2;255;255;255m\n"