-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LED Vu crashes GDS when no display present #414
Comments
for the record, the stack trace decodes as follow:
it seems like Music Assistant is sending some display commands even if there is no display. Could you try to disable the led vu and see if the issue is still happening? @philippe44 one way to prevend this would be to ensure that we have a valid display pointer in the GDS code. For example
|
I have the same issue and I am not using Music Assistant. |
@HA-TB303 do you have the led_vu enabled? |
I can confirm that disabling led vu fix the issue.
|
Yes indeed, disabling led vu fixed the issue for me as well. |
I'll have a look to see if I can see what's going on with led_vu |
Could be that led vu causes the system to report display support to the server. There may not be a choice other than adding some null checking in the GDS itself. |
I just pushed the following commit 21407e8 which I am hoping will resolve the issue. You can try installing the latest build when it will show up. |
Closing this now. Please reopen if needed |
Hey @sle118 Sorry, just get to test the latest build. Unfortunately, it is still crashing with a different error.
|
I'm leaving this for the record:
I'll try to have a look later tomorrow |
Apologies, been busy on other stuff. Just re-flashed one of my test systems with the latest version to test squeezelite-esp32 with HA Slimproto, As I suspected, there is a divide-by-zero issue with Ledvu when setting string length of 1. I'll work on a PR to fix it. Saying that, Ledvu is for visual effects on a string of multiple addressable leds. If you want to use a single WS2812 as a status light, use set-GPIO only. |
@sle118, the issue is with When I added LEDVU. I included an extra field to SETD. The display height reports 0 height, but currently In the time-being, we can fix with some extra checks in displayer. Do you want me to create a PR? |
Describe the bug
Home Assistant / Music Assistant has a built-in LMS server that allows using slimproto clients to play the audio directly from HA. Seems that some communication that comes from the built-in server crashes squeezelite-esp32.
When enabled squeezelite-esp32 immediately goes into the bootloop. As soon as disabled, it acts normally.
Preliminary Information
Hardware Details
NVS Settings
nvs_config_loud-esparagus_1714076880283json.txt
Logs
Issue Description
3.1. Make sure squeezelite-esp32 device boots and start LMS server discovery
3.2. Enable slimproto player provider in the HA / MA
3.3. Observe squeezelite-esp32 crash and bootloop within seconds.
If you guide me to investigate and possibly fix this issue, I would be happy to do it myself. From the looks of it, seems that message is malformed or at least does not look as expected. I tried to enable more logging via telnet, but this yield no more information that standard logs have
The text was updated successfully, but these errors were encountered: