reply to a comment doesn't nest like it does in the web interface

[PatrickvL]

No description provided.

[Tunous]

Got an example?

[PatrickvL]

Each and every time I've used the Reply button from within OctoDroid here, but instead it became separate comments​ : Cxbx-Reloaded/Cxbx-Reloaded#367

Edit: to be clear : I've used the Reply button from within the files tab, on a file, on review comments of others. As you can see in the screenshot posted there, my replies incorrectly ended up as new conversations.

[maniac103]

https://developer.github.com/v3/repos/comments/#create-a-commit-comment

I don't see any way to specify a reference to another commit there?

[maniac103]

Hmm, looks like it's possible with PR comments: https://developer.github.com/v3/pulls/comments/#create-a-comment (see 'alternative input' section)

[maniac103]

This should be reasonably easy to do. I'll look into it.

[PatrickvL]

Now that was quick! Thanks! Any idea how soon this lands in Google play so people can update OctoDroid the usual way?

[maniac103]

Ultimately it depends on @slapperwan, but I guess a soon-ish release totally makes sense for the web flow based oauth alone. I wanted to land the comment bottom sheet PR first, but it's probably better not to delay all the other new features for it.

@Tunous @slapperwan Thoughts on this?

[Tunous]

Yes, I think that earlier release is a good idea. Comment bottom sheet still needs some more bug fixes and I feel like a few more will pop up. This feature deserves its own release anyway ;) It could also come with some sort of drafts system that I'm thinking about implementing. I'll talk about this more in a new issue once I finish my base idea.

Just should merge #580 before releasing, and I also think that the mark all as read button from notifications screen should disappear once everything is marked read.

[slapperwan]

I'm currently testing from Master. Web flow oauth must go ASAP. Any other PR that need to be merged?