-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time to raise minSdkVersion? #1132
Comments
FWIW, our installation data in Google Play as of today:
So yeah, raising to API 19 (4.4) should not be a problem at all, but what will that buy us? AFAICT the real gains only start when bumping to API 21... |
Thanks for the info @maniac103.
Agree, I've actually thought of the bump to API 19 as a preliminary step for the transition to API 21. We can then bump to API 21 in a subsequent version of the app or just bump from 17 to 21 in a single version. A benefit I see in bumping, regardless of the API level, is that we can avoid the potential need for compatibility quirks (speaking of which, I've noticed that WebView on pre-KitKat devices uses a legacy engine with several behavior differences). What do you think? |
Probably yes, but I believe users that are on older versions would also be counted ... I guess that's the case for that one user.
I'm not sure why there would be a need for an intermediate step here? |
To reduce the risk of regressions, but maybe that risk isn't actually that high...?
GitHub requires TLS 1.2 since 2018, and Android supports it since API level 16. Although, according to this article, it seems that not all 4.1-4.4 devices are guaranteed to support TLS 1.2. |
Looking at #857, I think that updating to API 21+ may be a good idea after all. |
Also OkHttp 3.12.x becomes unsupported at the end of the year: https://square.github.io/okhttp/security/ |
Found other two good reasons to bump to SDK 21: 😃
Would you mind looking into doing the bump when you have some time? 🙏 |
@maniac103 , does Google Play count F-Droid installs too? Does F-Droid have such numbers? I migrated to F-Droid but Google Play still detects as installed. |
Closing since the minSdkVersion has been bumped in #1166. |
Currently, this app can be installed on devices down to Android 4.2.
Considering that some notable libraries used by this app (namely OkHttp and RxJava) have dropped support for Android <5, in my opinion it would make sense to aim for a bump to minSdkVersion 21 sooner or later.
It would also bring some neat benefits: no need for multidex and smaller APKs, since bitmap versions of vector drawables (for compatibility with pre-Lollipop devices) won't be bundled in the app.
We could start with a bump to minSdk 19, which should be painless and unlikely to affect more than a handful of users. Outdated 2020 Android distribution data showed that Android versions prior to 4.4 had the least amount of users (<2%), which should be even less today.
The text was updated successfully, but these errors were encountered: