Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgui_lua_bindings.pl improvements #18

Open
idbrii opened this issue Jul 26, 2017 · 0 comments
Open

imgui_lua_bindings.pl improvements #18

idbrii opened this issue Jul 26, 2017 · 0 comments

Comments

@idbrii
Copy link

idbrii commented Jul 26, 2017

I posted a bunch of PRs to patrickriordan/imgui_lua_bindings.

I see that you have your own improvements here too. Are you interested in merging some of these changes:
https://github.com/idbrii/imgui_lua_bindings/tree/all-the-pr

Most changes are in their own branch, but I've given up keeping them tidy and independent unless someone's interested in merging.

Summary:

  • combine-shared-logic
    • (DrawList and standard imgui functions
  • iterate-enums
    • provide all imgui enums under imgui.constant (e.g., imgui.constant.SetCond.Appearing)
  • lua-51
    • define to use lua 5.1 API
  • optional-strings
    • support default values for strings
  • string-return
    • support returning strings (I think you have this)
  • update-to-1.50
    • update to imgui 1.50 (final release is out!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant