Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Candidate v2.45.3 #1125

Merged
merged 11 commits into from
Nov 3, 2023
Merged

Release Candidate v2.45.3 #1125

merged 11 commits into from
Nov 3, 2023

Conversation

ruck314
Copy link
Contributor

@ruck314 ruck314 commented Nov 2, 2023

lorenzrota and others added 11 commits October 11, 2023 11:20
Added rst to Scrambler
6607e78
@ruck314
Merge pull request #1119 from slaclab/pgp4wrapper-fix
7554480 
Pgp4TxLiteWrapper: Bug fix in simulation with ASYNC reset
@ruck314
xilinx/_RfTile.py update
6d72db9 
powerOnSequenceSteps enum only defined for 4-bits (not 8-bits)
@ruck314
Pgp4TxLiteWrapper.vhd clean up
3afe17a 
whitespace removal
@ruck314
Merge pull request #1121 from slaclab/whitespace-removal
11fdf06 
Pgp4TxLiteWrapper.vhd clean up
@ruck314
Merge pull request #1120 from slaclab/RfTile-path
cddd5c7 
xilinx/_RfTile.py update
@ruck314
adding MtsAdcSync/MtsDacSync
f72491d
@ruck314
Merge pull request #1123 from slaclab/xrfdc_mts
46fa286 
adding MtsAdcSync/MtsDacSync
@ruck314
Lmx2594.py Update
0d8745f 
turn off SYNC after the stable state
@ruck314
bug fix for the LoadCodeLoaderHexFile() function
c7ae2a9
@ruck314
Merge pull request #1124 from slaclab/lmx2594-patch
850db38 
Lmx2594.py Update
@ruck314 ruck314 requested review from bengineerd and jumdz November 2, 2023 23:11
jumdz
jumdz approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@jumdz jumdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big issue with approving, only one question about the comments in the LMX2594.py script

python/surf/devices/ti/_Lmx2594.py Show resolved Hide resolved
@ruck314 ruck314 merged commit cede45e into master Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumdz jumdz jumdz approved these changes

@bengineerd bengineerd Awaiting requested review from bengineerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruck314 @jumdz