Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

SLKTextViewController will not dealloc if keyboard is open when controller is dismissed #234

Closed
joshbernfeld opened this issue Aug 16, 2015 · 3 comments
Labels

Comments

@joshbernfeld
Copy link

If the keyboard is visible on the SLKTextViewController and you pop the controller off the nav controller stack the SLKTextViewController will never be deallocated. I tested this with the provided example project. To recreate, use the programatic example and set the root view controller as a blank UIViewController and then push on the new SLKTextViewController. Open the keyboard, then press the back button, dealloc will not be called.

@joshbernfeld joshbernfeld changed the title SLKTextViewController will not dealloc if keyboard is open when popped off nav controller SLKTextViewController will not dealloc if keyboard is open when controller is dismissed Aug 16, 2015
@bradya bradya added the bug label Aug 20, 2015
@bradya
Copy link
Contributor

bradya commented Aug 20, 2015

Seeing this internally as well. We will be looking into this asap.

@joshbernfeld
Copy link
Author

Thanks for the quick fix. That did it 👍

@dzenbot
Copy link

dzenbot commented Aug 21, 2015

Thanks for the heads up! 🙌

bradya added a commit that referenced this issue Aug 21, 2015
Moves the 'inputAccessoryView' override to `SLKTextInputbar`. Fixes #234
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants