Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for FileInstallationStore #941

Closed
4 tasks done
stevengill opened this issue May 28, 2021 · 4 comments · Fixed by #1003
Closed
4 tasks done

Add Support for FileInstallationStore #941

stevengill opened this issue May 28, 2021 · 4 comments · Fixed by #1003
Assignees
Labels
enhancement M-T: A feature request for new functionality
Milestone

Comments

@stevengill
Copy link
Member

stevengill commented May 28, 2021

Description

In addition to the default MemoryInstallationStore, BoltJS should offer the option of a FileInstallationStore. Developers can import this new store and use it instead of the default for a more persistent storage experience.

What type of issue is this? (place an x in one of the [ ])

  • enhancement (feature request)

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@stevengill stevengill added the enhancement M-T: A feature request for new functionality label May 28, 2021
@misscoded misscoded self-assigned this May 28, 2021
@seratch
Copy link
Member

seratch commented Jul 2, 2021

This is related to slackapi/node-slack-sdk#1278
@misscoded Do we have things to do on the bolt-js side?

@seratch seratch added this to the 3.5.0 milestone Jul 2, 2021
@seratch
Copy link
Member

seratch commented Jul 14, 2021

Once the @slack/oauth package switches the default to the file installation store, we can close this issue.

@misscoded
Copy link
Contributor

@seratch

Do we have things to do on the bolt-js side?

Apologies, I missed this -- I believe the only thing to be done on the Bolt side is to ensure that it's imported/exported from the @slack/oauth side of things. And any associated documentation, if applicable.

I almost think it worth narrowing/editing this issue to just be FileInstallationStore to accurately reflect the work that's been done. Thoughts?

@seratch
Copy link
Member

seratch commented Jul 14, 2021

@misscoded

I almost think it worth narrowing/editing this issue to just be FileInstallationStore to accurately reflect the work that's been done. Thoughts?

I totally agree on this 👍

@misscoded misscoded changed the title Create new installation Stores Add Support for FileInstallationStore Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants