right bug fix #665 #676
Closed
right bug fix #665 #676
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is mouseup better or more correct than mousedown? |
|
mousedown its fast but user can do other events before last events was the end |
|
Sure some interactions like highlighting the dropdown text would not be possible but I'm not sure any are common nor merit support. The reason click was changed is it caused loss of focus issues that are prevented with mousedown + preventDefault. If there's a common interaction that's lost that should be supported feel free to re-comment to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
item.addEventListener('click', this.selectItem.bind(this, item, true));//bug #665
may be correct to fix the compiler
its compilate in:
['mousedown', 'touchstart'].forEach(function (name) {
item.addEventListener(name, function (event) {
_this2.selectItem(item, true);
event.preventDefault();
});
});
what we need:
['mouseup', 'touchend'].forEach(function (name) {
item.addEventListener(name, function (event) {
_this2.selectItem(item, true);
event.preventDefault();
});
});