Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When colors bar is opened focus disappeared #2172

Closed
AlexanderKuzmichev opened this issue Jun 27, 2018 · 3 comments
Closed

When colors bar is opened focus disappeared #2172

AlexanderKuzmichev opened this issue Jun 27, 2018 · 3 comments

Comments

@AlexanderKuzmichev
Copy link

Steps for Reproduction

  1. Visit https://codepen.io/anon/pen/MXPVYo
  2. Select 'select_me' text
  3. Open colors bar (click the only button on toolbar)

Expected behavior:
Colors bar is opened, selection and focus isn't changed

Actual behavior:
Colors bar is opened, selection and focus disappeared

Platforms:
Chrome Version 67.0.3396.99 (Official Build) (64-bit), Windows 10

Version:
1.3.6

@Joeao
Copy link
Contributor

Joeao commented Aug 10, 2018

Noticed this today too on Firefox.
I checked out your codepen and reverted a bunch of versions, turns out this issue started occurring from version 1.0.6. It also occurs in 2.0.0-dev.2, so seems to be something worth pursuing. Will dig deeper.

@Joeao
Copy link
Contributor

Joeao commented Aug 10, 2018

Looks like c70455d is the commit that caused this issue. I put the code back into 1.0.6 and 1.3.6 and the issue disappeared. However these lines were removed to fix another issue so simply adding it back isn't really an option.


Also checked if issue #997 still exists if this code was put back, and it does. Going to have to leave it to the higher powers to decide how to fix this one.

@quill-bot
Copy link

Quill 2.0 has been released (announcement post) with many changes and fixes. If this is still an issue please create a new issue after reviewing our updated Contributing guide 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants