-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text formatting stops working correctly if selection ends outside of document [Chrome] #1645
Comments
What do you mean by "Quill stops responding"? In my test the selected text isn't getting attributes if releasing the mouse outside the browser window:
Expected behaviour: Actual behaviour: Platforms: Version: |
Sorry for the confusion with the description, I've tried to update it a little bit. I experienced the same kind of problems you have, but also none of the quill events seem to fire any more. On the examples with floating toolbar, the toolbar doesn't appear anymore after selecting text. What may be of help is that formatting with keyboard shortcuts works as expected. |
I can confirm this also happens in Safari. |
I can also confirm that reverting to 1.3.0 fixes this problem. So something in 1.3.1 changed. |
It appears it may have something to do with this commit: d30e36d |
It's not possible to apply formatting if user is selecting text and releases mouse outside of the document where quill was instantiated, or outside of the browser window. Quill events don't seem to be fired anymore after such action.
Steps for Reproduction
Expected behaviour:
Formatting text should works as intended
Actual behaviour:
Not possible to format selection with buttons, keyboard formatting works correctly
Platforms:
Chrome 60.0.3112.90
OSX 10.12.5 & Windows 10
Version:
1.3.1
The text was updated successfully, but these errors were encountered: