Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: update cpu quota for the server #2266

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

nic11
Copy link
Collaborator

@nic11 nic11 commented Dec 12, 2024

Important

Update CPU quota in branchctl.sh to allocate 6 CPU cores for the server container.

  • Resource Allocation:
    • Update CPU quota in branchctl.sh from 50% of a single core to 6 CPU cores using --cpu-quota=$(( 50000 * 6 )).
    • Comment updated to reflect new CPU core allocation.

This description was created by Ellipsis for 33baeef. It will automatically update as commits are pushed.

@nic11 nic11 marked this pull request as ready for review December 12, 2024 09:39
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 33baeef in 14 seconds

More details
  • Looked at 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. misc/deploy/remote/branchctl.sh:25
  • Draft comment:
    The comment should clarify that the CPU quota is set to 6 CPU cores, not just limited to 6 cores. Consider rephrasing for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in CPU quota calculation is correct, but the comment should be updated for clarity.

Workflow ID: wflow_FPew11zHezMyB4Hx


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Pospelove Pospelove merged commit 6058819 into skyrim-multiplayer:main Dec 12, 2024
10 checks passed
@Pospelove Pospelove deleted the upd-cpulimit branch December 12, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants