Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: add clang-format to the dev image #2259

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

nic11
Copy link
Collaborator

@nic11 nic11 commented Dec 6, 2024

Important

Add clang-format-15 to Dockerfile for code formatting support in the dev image.

  • Dockerfile Update:
    • Add clang-format-15 to the list of installed packages in Dockerfile to support code formatting.

This description was created by Ellipsis for 78e36ec. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 78e36ec in 6 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. Dockerfile:46
  • Draft comment:
    Adding clang-format-15 is consistent with the existing clang-15 installation, ensuring code formatting tools are available in the development environment.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The addition of clang-format-15 is consistent with the existing clang-15 installation, ensuring that the development environment has the necessary tools for code formatting. This is a straightforward addition to the Dockerfile.

Workflow ID: wflow_8OIYeQvOkP3gtREl


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Pospelove
Copy link
Contributor

I added it here https://github.com/skyrim-multiplayer/skymp/blob/main/.devcontainer/Dockerfile

I would recommend trying devcontainers, VS Code supports them. But if u wish we can add it here too. Approve

@nic11
Copy link
Collaborator Author

nic11 commented Dec 7, 2024

It's like 50-60 extra KB in the image and would let anyone easily run the same formatting that is expected, if they already build using that.

But yeah we can try building devcontainers, rn I see that at least some flags that are written in the docs can be instead specified in the config https://containers.dev. Although I would prefer them to have support for podman --userns=keep-id. Not sure if it's easily adjustable in the current state

@Pospelove Pospelove merged commit 2c7d8a5 into skyrim-multiplayer:main Dec 7, 2024
10 of 11 checks passed
@Pospelove Pospelove deleted the upd-dockerfile-3 branch December 7, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants