Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skymp5-server): add Quest.GetStage stub & disable some bad scripts #2256

Merged
merged 13 commits into from
Dec 9, 2024

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Dec 6, 2024

Important

Add PapyrusQuest class with quest stage methods, logging unimplemented status, and fix registration typo.

  • New Class:
    • PapyrusQuest added to handle quest-related functionality.
    • Implements GetStage and GetCurrentStageID methods.
  • Functionality:
    • GetStage calls GetCurrentStageID.
    • GetCurrentStageID logs a warning and returns 0, indicating it's not implemented.
  • Registration:
    • Registers methods with VirtualMachine in Register().
    • Typo in registration: uses PapyrusPotion instead of PapyrusQuest.

This description was created by Ellipsis for 03d0fc0. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev bot changed the title . feat: add PapyrusQuest class with quest stage methods and logging Dec 6, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 03d0fc0 in 39 seconds

More details
  • Looked at 69 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skymp5-server/cpp/server_guest_lib/script_classes/PapyrusQuest.cpp:35
  • Draft comment:
    The methods registered in PapyrusQuest::Register are incorrectly referencing PapyrusPotion instead of PapyrusQuest. This will cause a compilation error or incorrect behavior.
  AddMethod(vm, "GetCurrentStageID", &PapyrusQuest::GetCurrentStageID);
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_4rado9IWI7tSjcyy


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Pospelove Pospelove changed the title feat: add PapyrusQuest class with quest stage methods and logging feat(skymp5-server): add Quest.GetStage stub Dec 6, 2024
Pospelove and others added 8 commits December 6, 2024 15:41
….cpp

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@Pospelove Pospelove changed the title feat(skymp5-server): add Quest.GetStage stub feat(skymp5-server): add Quest.GetStage stub & disable some bad scripts Dec 6, 2024
@Pospelove Pospelove merged commit e1235f0 into skyrim-multiplayer:main Dec 9, 2024
9 of 10 checks passed
@Pospelove Pospelove deleted the stubgetstage branch December 9, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant