-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(skymp5-server): add Quest.GetStage stub & disable some bad scripts #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellipsis-dev
bot
changed the title
.
feat: add PapyrusQuest class with quest stage methods and logging
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 03d0fc0 in 39 seconds
More details
- Looked at
69
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skymp5-server/cpp/server_guest_lib/script_classes/PapyrusQuest.cpp:35
- Draft comment:
The methods registered inPapyrusQuest::Register
are incorrectly referencingPapyrusPotion
instead ofPapyrusQuest
. This will cause a compilation error or incorrect behavior.
AddMethod(vm, "GetCurrentStageID", &PapyrusQuest::GetCurrentStageID);
- Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_4rado9IWI7tSjcyy
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
skymp5-server/cpp/server_guest_lib/script_classes/PapyrusQuest.cpp
Outdated
Show resolved
Hide resolved
Pospelove
changed the title
feat: add PapyrusQuest class with quest stage methods and logging
feat(skymp5-server): add Quest.GetStage stub
Dec 6, 2024
Pospelove
changed the title
feat(skymp5-server): add Quest.GetStage stub
feat(skymp5-server): add Quest.GetStage stub & disable some bad scripts
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
PapyrusQuest
class with quest stage methods, logging unimplemented status, and fix registration typo.PapyrusQuest
added to handle quest-related functionality.GetStage
andGetCurrentStageID
methods.GetStage
callsGetCurrentStageID
.GetCurrentStageID
logs a warning and returns 0, indicating it's not implemented.VirtualMachine
inRegister()
.PapyrusPotion
instead ofPapyrusQuest
.This description was created by for 03d0fc0. It will automatically update as commits are pushed.