Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: add Discord webhook for gamemode deploy workflow #2246

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Dec 4, 2024

Important

Add Discord notifications for deployment start and failure in deploy_gamemode.yml.

  • Notifications:
    • Add step to post a link in Discord when gamemode deployment starts in .github/workflows/deploy_gamemode.yml.
    • Add step to notify Discord on deployment failure or cancellation in .github/workflows/deploy_gamemode.yml.

This description was created by Ellipsis for 03668b5. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 03668b5 in 16 seconds

More details
  • Looked at 43 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. .github/workflows/deploy_gamemode.yml:40
  • Draft comment:
    Ensure that './misc/deploy/call_webhook.sh' exists and is executable to avoid runtime errors.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The added step for posting a link in Discord is a good addition for tracking purposes. However, the script path './misc/deploy/call_webhook.sh' should be verified to ensure it exists and is executable.
2. .github/workflows/deploy_gamemode.yml:92
  • Draft comment:
    Ensure that './misc/deploy/call_webhook.sh' exists and is executable to avoid runtime errors.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The 'Notify failure' step is a good addition for alerting on failures. However, the script path './misc/deploy/call_webhook.sh' should be verified to ensure it exists and is executable.

Workflow ID: wflow_G8IMSDTsa0XIjmbx


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Pospelove Pospelove changed the title Update deploy_gamemode.yml internal: add Discord webhook for gamemode deploy workflow Dec 4, 2024
@Pospelove Pospelove merged commit 9566037 into main Dec 4, 2024
11 of 15 checks passed
@Pospelove Pospelove deleted the Pospelove-patch-4 branch December 4, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant