fix(skymp5-client): prevent profiling file overwrites by adding random suffix #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellipsis-dev
bot
changed the title
Pospelove
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 0015e1a in 33 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_ANluMcS8Lre2MLCa
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -62,7 +62,8 @@ export class ProfilingService extends ClientListener { | |||
| }); | |||
| }); | |||
|
|
|||
| fs.writeFileSync('./profile.cpuprofile', JSON.stringify(profile)); | |||
| const fileNameSuffix = Math.random().toString().replace(".0", ""); | |||
| fs.writeFileSync(`./profile${fileNameSuffix}.cpuprofile`, JSON.stringify(profile)); | |||
There was a problem hiding this comment.
Consider using a more robust method for generating unique file names, such as incorporating a timestamp or using a UUID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add random suffix to profiling output file names in
ProfilingServiceto prevent overwrites.ProfilingServiceto include a random suffix, preventing overwrites ofprofile.cpuprofilefiles.This description was created by
for 0015e1a. It will automatically update as commits are pushed.