-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runpod docker credentials not working when using image_id from private repository #4269
Comments
also unrelated but it would be nice to be able to specify multiple cloud providers in the yaml |
This is supported; check out https://skypilot.readthedocs.io/en/latest/examples/auto-failover.html#multiple-candidate-resources. |
Got it, thanks. Any idea about the docker credentials? |
It can be an issue with our pumping for the docker credentials for RunPod specifically. cc'ing @cblmemo for a look. |
Yes, this is due to we directly setting the image id to create pod instead of using the DockerInitializer. A solution would be manually calling the runpod credential API if env variables is detected. Will submit a PR to fix this. |
@cblmemo how can I help get this resolved? I'm happy to contribute however needed :) |
Thanks for pinging! I'll take a look today. Could you share which docker registry are you using right now? This can help us debug :)) |
thank you! I'm using dockerhub right now for the ML images. |
Thanks for the information! #4287 should work now. I tested with AWS ECR and it mostly works well except for some runpod api issue. Are you interested to test it out? |
Sure thing, is it in the latest version of sky or do I need to do something different? |
Try installing from source and checkout this branch: git clone https://github.com/skypilot-org/skypilot.git
cd skypilot
git switch runpod-docker-login
pip install -e ".[all]" |
sorry about that! I've been very busy recently, do you still need me to test it out? |
We've already tested and merged it! Now it should be available on the nightly build. Feel free to try it out and see if that resolves your requirement! |
Because runpod doesn't support docker I need to use my docker image as the base image_id but setting the
SKYPILOT_DOCKER_USERNAME
andSKYPILOT_DOCKER_PASSWORD
doesn't allow the created runpod to have access to the private repo. However, if you manually change the dockerhub config on the runpod web UI (which I setup beforehand) it works fine. Is there a way to authenticate the docker image for the created pod automatically?For reference here's my config:
and then an image of the runpod UI that I'm referring to:
Version & Commit info:
sky -v
: skypilot, version 0.7.0sky -c
: 3f62588The text was updated successfully, but these errors were encountered: