Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] SkyPilot conda shadows pre-configured environment in docker containers #3741

Closed
romilbhardwaj opened this issue Jul 10, 2024 · 1 comment · Fixed by #3874
Closed
Labels
good first issue Good for newcomers P0

Comments

@romilbhardwaj
Copy link
Collaborator

When using docker containers as the runtime environment (image_id: docker:...), SkyPilot's installed conda gets activated by default during run, setup and when you ssh. This trips up users, who may have configured their envs without conda:

Examples include nemo and vllm images:

sky launch --image-id docker:vllm/vllm-openai:latest

# python -m vllm.entrypoints.openai.api_server does not work without conda deactivate

Our vLLM yaml also does the same:

More quotes from users:

vllm image doesn’t work super well as a base image for skypilot. Doesn’t seem to have anything useful installed
...
explains why my past attempts to use this approach all failed

Another user runs on k8s with custom image. He is forced to runs conda deactivate in the YAMLs he shared with us.

We should probably not activate conda by default when docker image is specified.

@romilbhardwaj
Copy link
Collaborator Author

Related to #3697.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants