Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Managed Jobs] Support Rsync for managed jobs #3620

Closed
hemildesai opened this issue May 31, 2024 · 5 comments
Closed

[Managed Jobs] Support Rsync for managed jobs #3620

hemildesai opened this issue May 31, 2024 · 5 comments
Labels

Comments

@hemildesai
Copy link
Contributor

hemildesai commented May 31, 2024

Currently, managed jobs automatically translate local files and workdir to cloud bucket mounts. This means that managed jobs cannot be launched if a user does not have access to cloud storage.

I am wondering if its possible to support rsync for workdir and local files in managed jobs where the jobs controller will essentially act as a jump host for the rsync. So the flow would be to rsync to jobs controller first, then rsync from the jobs controller to the jobs which are launched by the controller.

Ideally, this should be bidirectional - i.e. later on, it should also be possible to rsync back any changes to the workdir from the controller to the local machine.

@romilbhardwaj
Copy link
Collaborator

+1 - this is important for the Kubernetes-only case where the user does not have access to any cloud object store.

@hemildesai
Copy link
Contributor Author

hemildesai commented Jun 1, 2024

@romilbhardwaj In the k8s only use case, managed jobs would also need to support the jobs controller being launched in k8s. Right now, autostop is set on the jobs controller which means it will fail to launch in k8s IIRC

@romilbhardwaj
Copy link
Collaborator

Running controllers on Kubernetes is supported now :) We updated the downstream code to skip autostop for Kubernetes in #3377:

# Skip stop feature for Kubernetes controllers.
if (isinstance(to_provision.cloud, clouds.Kubernetes) and
controller_utils.Controllers.from_name(cluster_name)
is not None):
assert (clouds.CloudImplementationFeatures.STOP
in requested_features), requested_features
requested_features.remove(
clouds.CloudImplementationFeatures.STOP)

Copy link
Contributor

github-actions bot commented Oct 4, 2024

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Oct 4, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants