Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s] Ingress paths for exposing ports need to be namespaced #3372

Closed
romilbhardwaj opened this issue Mar 26, 2024 · 0 comments · Fixed by #3373
Closed

[k8s] Ingress paths for exposing ports need to be namespaced #3372

romilbhardwaj opened this issue Mar 26, 2024 · 0 comments · Fixed by #3373
Labels
k8s Kubernetes related items

Comments

@romilbhardwaj
Copy link
Collaborator

Our current ingress paths are http://<IP>/skypilot/<cluster>/<port>.

However, in a multi-namespaced environment this may have collisions if two clusters have the same name but in different namespaces.

We should change to http://<IP>/skypilot/<namespace>/<cluster>/<port>

Need to think about backward compatibility here (might be ok since #3109 is not merged yet?).
@romilbhardwaj romilbhardwaj added the k8s Kubernetes related items label Mar 26, 2024
@romilbhardwaj romilbhardwaj mentioned this issue Mar 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
k8s Kubernetes related items
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[k8s] Make ingress paths namespace aware skypilot-org/skypilot
1 participant
@romilbhardwaj