Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkyServe: warn/raise on min_replicas: 0 #2893

Closed
concretevitamin opened this issue Dec 22, 2023 · 4 comments · Fixed by #2895
Closed

SkyServe: warn/raise on min_replicas: 0 #2893

concretevitamin opened this issue Dec 22, 2023 · 4 comments · Fixed by #2895

Comments

@concretevitamin
Copy link
Member

Tried the http server example with min_replicas: 0 and got

Services
NAME  UPTIME  STATUS        REPLICAS  ENDPOINT
http  -       REPLICA_INIT  0/0       172.190.62.140:30001

Service Replicas
No existing replicas.

At this point there's no way to curl and trigger a scale-up.

We should consider raising a ValueError / NotImplementedError about this.

cc @MaoZiming @cblmemo

@MaoZiming MaoZiming linked a pull request Dec 22, 2023 that will close this issue
5 tasks
@cblmemo
Copy link
Collaborator

cblmemo commented Dec 23, 2023

Humm, did you specify max_replicas=<some positive integer>? If not, the default value of max_replicas is min_replicas, and no autoscaling is enabled. I think if you specify min_replicas=0, max_replicas=1 and curl the endpoint, then it will trigger a scale-up.

@cblmemo cblmemo reopened this Dec 23, 2023
@MaoZiming
Copy link
Collaborator

MaoZiming commented Dec 23, 2023

@cblmemo I think we need special handling for min_replicas=0, I believe currently it will take multiple curl's + some delay to trigger a scale-up when num replicas is 0.
User might prefer immediate scale-up when there is request.
It also shows REPLICA_INIT when there is no replica with no scale-up.

@concretevitamin
Copy link
Member Author

+1. I believe I set min_replicas: 0 and max_replicas: 1.

@cblmemo
Copy link
Collaborator

cblmemo commented Dec 24, 2023

Sounds great! Lets keep min_replicas>0 for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants