Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Pre-checks for ~/.sky/config.yaml #2474

Closed
Michaelvll opened this issue Aug 27, 2023 · 3 comments · Fixed by #2645
Closed

[config] Pre-checks for ~/.sky/config.yaml #2474

Michaelvll opened this issue Aug 27, 2023 · 3 comments · Fixed by #2645
Assignees
Labels
enhancement New feature or request friction-log good first issue Good for newcomers

Comments

@Michaelvll
Copy link
Collaborator

Currently, we don't have a way to pre-check the ~/.sky/config.yaml, making it very easy to miss spell or setting wrong configs in the yaml. We can apply the json schema check to the ~/.sky/config.yaml to make sure there is no unexpected settings.

A user met the issue when specifying the spot controller's resources requirement, but missing one section (resources):

spot:
  controller:
    cloud: gcp
    region: us-west1
@Michaelvll Michaelvll added enhancement New feature or request friction-log good first issue Good for newcomers labels Aug 27, 2023
@djokester
Copy link

Can I pick this up?

@concretevitamin
Copy link
Member

#2600 ran into this.

@iojw
Copy link
Collaborator

iojw commented Sep 28, 2023

Let me know if you're still interested in picking this up @djokester! Happy to guide you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request friction-log good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants