Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old maximum grpcio version is blocking other dependencies #1956

Closed
christophbergemann opened this issue May 12, 2023 · 4 comments
Closed

Old maximum grpcio version is blocking other dependencies #1956

christophbergemann opened this issue May 12, 2023 · 4 comments

Comments

@christophbergemann
Copy link

skypilot requires grpcio<=1.43.0, which is quite old. This is causing unresolvable version conflicts in some cases. While my example (below) may be quite a particular use case, I think this is going to be a more general problem.

My example is using

pymilvus>=2.2.8
skypilot>=0.2.5

leading to

The conflict is caused by:
    pymilvus 2.2.8 depends on grpcio<=1.53.0 and >=1.49.1
    skypilot 0.2.5 depends on grpcio<=1.43.0 and >=1.32.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict
@concretevitamin
Copy link
Member

@christophbergemann
Copy link
Author

christophbergemann commented May 12, 2023

Running on Windows 11 with Python 3.10.
Edit: Also reproducible on Gentoo Linux with Python 3.11 (although that's no surprise)

@Michaelvll
Copy link
Collaborator

Michaelvll commented May 12, 2023

Good point! It seems the problem has been solved by the upstream ray>=2.1. Since we currently using ray==2.0.1, we are blocked by the #1734.
https://github.com/ray-project/ray/blob/ray-2.0.1/python/setup.py
https://github.com/ray-project/ray/blob/ray-2.1.0/python/setup.py

@concretevitamin
Copy link
Member

This has now been relaxed in 0.3:

"grpcio >= 1.32.0, <= 1.49.1; python_version < '3.10' and sys_platform == 'darwin'", # noqa:E501
"grpcio >= 1.42.0, <= 1.49.1; python_version >= '3.10' and sys_platform == 'darwin'", # noqa:E501
# Original issue: https://github.com/ray-project/ray/issues/33833
"grpcio >= 1.32.0, <= 1.51.3; python_version < '3.10' and sys_platform != 'darwin'", # noqa:E501
"grpcio >= 1.42.0, <= 1.51.3; python_version >= '3.10' and sys_platform != 'darwin'", # noqa:E501

Please feel free to reopen this if it doesn't fix the issue for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants