Invalid cluster name is generated if username has uppercase or invalid characters

[romilbhardwaj]

If the user does not specify a cluster name, we randomly generate a name appended with the username appended to it. E.g.,

$ sky launch example.yaml
...
Launching a new cluster 'sky-7ccb-romilb'. Proceed? [Y/n]:

If the username has underscores or capital letters then it generates an invalid cluster name which fails our regex check:

skypilot/sky/backends/backend_utils.py

Lines 1809 to 1826 in 10967e6

	def check_cluster_name_is_valid(cluster_name: str,
	cloud: Optional[clouds.Cloud] = None) -> None:
	"""Errors out on invalid cluster names not supported by cloud providers.
	Bans (including but not limited to) names that:
	- are digits-only
	- contain underscore (_)
	"""
	if cluster_name is None:
	return
	# GCP errors return this exact regex. An informal description is at:
	# https://cloud.google.com/compute/docs/naming-resources#resource-name-format
	valid_regex = '[a-z]([-a-z0-9]{0,61}[a-z0-9])?'
	if re.fullmatch(valid_regex, cluster_name) is None:
	with ux_utils.print_exception_no_traceback():
	raise ValueError(
	f'Cluster name "{cluster_name}" is invalid; '
	f'ensure it is fully matched by regex: {valid_regex}')

ValueError: Cluster name "sky-6948-rOmILB" is invalid; ensure it is fully matched by regex: [a-z]([-a-z0-9]{0,61}[a-z0-9])?

We should maybe run .lower() on the username and remove any invalid characters from it when generating cluster name.

[Akshat977]

Hi @romilbhardwaj ,
This issue seems to be a good initiation of my journey towards contribution to FOSS projects.
Can you please assign this to me?

[romilbhardwaj]

Thanks for taking this up @Akshat977!

[michaelzhiluo]

Any updates on this Git issue @Akshat977 ?

[Michaelvll]

Hey @Akshat977, since we did not hear back from you for a long time, we will reassign the issue soon. Please tell us your progress, if you are working on it. : )

[Akshat977]

Hey @Michaelvll , can you please review my pull request?