Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple fix to duplicate/overlapping logcat windows. #1761

Merged
merged 3 commits into from
Jan 21, 2023

Conversation

zach-snell
Copy link
Contributor

Could be improved by not re-creating UI every time

Description

Quick fix for logcat debug window causing duplicate windows and incorrect displayed content.

#1752

Copy link
Owner

@skylot skylot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I will apply removing of trailing spaces.

jadx-gui/src/main/java/jadx/gui/ui/panel/LogcatPanel.java Outdated Show resolved Hide resolved
jadx-gui/src/main/java/jadx/gui/ui/panel/LogcatPanel.java Outdated Show resolved Hide resolved
jadx-gui/src/main/java/jadx/gui/ui/panel/LogcatPanel.java Outdated Show resolved Hide resolved
@skylot
Copy link
Owner

skylot commented Jan 18, 2023

I think this can be used as quick fix until @jmlitfi apply changes mentioned in #1752 (comment)

Copy link
Owner

@skylot skylot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another try to fix trailing spaces using GitHub suggestions 🤣

jadx-gui/src/main/java/jadx/gui/ui/panel/LogcatPanel.java Outdated Show resolved Hide resolved
jadx-gui/src/main/java/jadx/gui/ui/panel/LogcatPanel.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants