Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to include/exclude dependencies when saving #1467

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

NASGregorio
Copy link
Contributor

By default, when a class filter is applied, only the matching files will be saved.
Alternatively, "setIncludeDependencies(true)" can be used to also have them saved.

Fix #1466

@skylot
Copy link
Owner

skylot commented Apr 26, 2022

@NASGregorio you fix is working, but you just disable all work of DecompilerScheduler 🥲
So I add a commit to not save excluded classes by classFilter while processing dependencies as needed.
Please check these changes for your test case.

@NASGregorio
Copy link
Contributor Author

@skylot Sorry for the trouble.
I just tested it and it has the expected behaviour 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add "SkipDependencies" argument to not save dependencies to disk
2 participants