-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gui] "Save Mappings" doesn't save all of them. #2220
Comments
@ReDJstone it will be very helpful if you share APK file (or link to it) and full name of node which not saving in mappings file after rename. With that info, it will be easier to reproduce this issue 🙂 |
Nevermind.
I can't upload the file, it allows 25MB max. Any file that's been obfuscated with ProGuard will probably start throwing exceptions the same way if you start making mappings for it. I'm not going to do that anymore. |
Issue details
When i Save Mappings, some do not save into the text file.
(No type of file works. I tried. Though I'm using recaf simple to be able to see the text easily.)
But if i do not close the app, i can
Save Mappings
, thenClose Mappings
andOpen Mappings
using the same file, and every single mapping is exactly as i left it.This feels strange, because as i said, some mappings that reappear when i open the mappings file are not saved there at all!
But the real problem comes when closing the app.
The next time i open it, i try to
Open Mappings
and now it loads only the ones that are in the text file. The ones that are not in there, are lost.When changing the name of some variables, i get exceptions on the console.
And when i save, the variable does not get saved in the mappings file.
Jadx version
dev
Java version
22.0.2
OS
The text was updated successfully, but these errors were encountered: