Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mapper.md typo #288

Merged
merged 1 commit into from
Apr 14, 2024
Merged

fix: mapper.md typo #288

merged 1 commit into from
Apr 14, 2024

Conversation

rhkrwngud445
Copy link
Contributor

안녕하세요 재웅님 라이브러리 잘 활용하고 있습니다!
사용하다가 문서에 조금의 오탈자�를 발견하여 PR 올립니다!
mapper.md) apiErrorResponse -> apiSuccessResponse on SuccessPosterMapper

Hello �skydoves, I am using the library well!
While using it, I found a few typos in the document and am uploading a PR.
mapper.md) apiErrorResponse -> apiSuccessResponse on SuccessPosterMapper

🎯 Goal

Fix typo

🛠 Implementation details

mapper.md) apiErrorResponse -> apiSuccessResponse on SuccessPosterMapper

✍️ Explain examples

�NA

Preparing a pull request for review

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

Then dump binary APIs of this library that is public in sense of Kotlin visibilities and ensures that the public binary API wasn't changed in a way that makes this change binary incompatible.

./gradlew apiDump

Please correct any failures before requesting a review.

Code reviews

All submissions, including submissions by project members, require review. We use GitHub pull requests for this purpose. Consult GitHub Help for more information on using pull requests.

apiErrorResponse -> apiSuccessResponse on SuccessPosterMapper
@rhkrwngud445 rhkrwngud445 requested a review from skydoves as a code owner April 14, 2024 14:55
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for your contribution 👍

@skydoves skydoves merged commit a0d43dc into skydoves:main Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants