Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not depend on external sites #67

Closed
nono-gdv opened this issue Feb 14, 2020 · 3 comments · Fixed by #68
Closed

Do not depend on external sites #67

nono-gdv opened this issue Feb 14, 2020 · 3 comments · Fixed by #68
Assignees

Comments

@nono-gdv
Copy link

Hello,

Currently several URLs under https://maxcdn.bootstrapcdn.com/, https://code.jquery.com/ and https://cdnjs.cloudflare.com/ are hardcoded in the templates. Would it be possible to expose these URLs are configuration options rather than depending on third parties?

@skx
Copy link
Owner

skx commented Feb 14, 2020

I can appreciate some people might prefer to avoid using those locations, but I'd be a little concerned that adding three new configuration options is a bit much for such a simple project.

I think the better approach would be to embed the resources in the binary, that way users don't need an external service and I don't need to deal with a potentially growing list of configuration flags.

(I already do that for /jquery.tablesorter.min.js, though I'd want to make the way that is served more general; probably adding a "404-handler" which will detect requests to routes that are unknown and serve embedded resources if they can be handled that way.)

Does that seem like a good compromise for you?

@nono-gdv
Copy link
Author

Yes, that would be perfect!

@skx skx self-assigned this Feb 14, 2020
@skx skx mentioned this issue Feb 15, 2020
@skx skx closed this as completed in #68 Feb 15, 2020
@skx
Copy link
Owner

skx commented Feb 15, 2020

Fixed in #68, available in release-1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants