Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new dynamic CSS param --mobile-name-font-size support #15

Open
skullzarmy opened this issue Oct 13, 2023 · 0 comments
Open

new dynamic CSS param --mobile-name-font-size support #15

skullzarmy opened this issue Oct 13, 2023 · 0 comments
Labels
hacktoberfest Easy first-time contribution for Hacktoberfest

Comments

@skullzarmy
Copy link
Owner

skullzarmy commented Oct 13, 2023 •
edited
Loading

Issue

Component has support for separate mobile and standard font sizes, and separate standard and name font sizes, but no mobile name font size. This leaves the name small or similar size on mobile layouts.

Solution

  • Define --mobile-name-font-size for each variant in fontVariants. Ensure name is slightly larger than body text.
  • Define font-size in @media query using --mobile-name-font-size variable.
  • Review all variants in mobile and desktop sizing to ensure proper styling. (example.html can be useful for this)
@skullzarmy skullzarmy added the hacktoberfest Easy first-time contribution for Hacktoberfest label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Easy first-time contribution for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skullzarmy