Match Union's sort order with enum's and with sort order in 4.x #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorchik
changed the title
vkorchik
force-pushed
the
feature/union-sort-order-fix
branch
from
4897104 to
2f1b2fc
Compare
vkorchik
changed the title
|
@sksamuel , could you please review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like annotation
@AvroSortPrioritysorts records in Union in reversed order comparing with Enums, as well as with Enums/Unions fromavro4s:4.x.Probably the reason is a sort order here in Subtypes. Comparing with enums in 5.x and unions in 4.x, it seems to me that the Ordering compares A with B - ascending order, when instead it should compare B to A - descending.
Since
AvroSortPriorityis descending-based (if we could say so), then there should beB compare A.The same (but reversed) issue with
AvroUnionPositionwill be automatically resolved since these two annotations are tightly coupled anyway.