Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seven/add shipping cost attribute to order #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kyrpas
Copy link
Contributor

@kyrpas kyrpas commented Jul 10, 2023

@kyrpas kyrpas requested a review from tassosMaurides July 10, 2023 08:51
@kyrpas kyrpas self-assigned this Jul 10, 2023
Copy link

@tassosMaurides tassosMaurides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have revert commits, maybe we should remove the original commits and reverts if they are not needed

@@ -23,6 +23,7 @@ Name | Type | Value | Description
`fulfilled_by_skroutz` | Boolean | | Whether the order is fulfilled by skroutz
`fbs_delivery_note` | String | | Order's delivery note from warehouse for orders that are fulfilled by Skroutz
`store_pickup` | Boolean | | Whether the order will be picked up by the user at the store
`shipping_cost` | Double | | The order's shipping cost in euros (only for Fulfilled by Merchant orders, `0` for all other orders)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we changed that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks! Fixed and force pushed again.

@kyrpas kyrpas force-pushed the seven/add-shipping-cost-attribute-to-order branch from 479465a to b8a49fb Compare July 12, 2023 10:46
@kyrpas kyrpas force-pushed the seven/add-shipping-cost-attribute-to-order branch from b8a49fb to c453651 Compare July 12, 2023 10:52
Copy link
Contributor

@alexandrosth alexandrosth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants